xfs
[Top] [All Lists]

[PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu, 14 Nov 2013 14:54:02 -0600
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
The commit:

800db1c1 libxfs: refactor libxfs_buf_read_map for xfs_db

introduced a stray semicolon during the refactoring.  Luckily it
only breaks the error case.

(Caught by Coverity, CID 1128894)

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 0aa2eba..0219a08 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -754,7 +754,7 @@ libxfs_readbufr_map(struct xfs_buftarg *btp, struct xfs_buf 
*bp,
                offset += len;
        }
 
-       if (!error);
+       if (!error)
                bp->b_flags |= LIBXFS_B_UPTODATE;
 #ifdef IO_DEBUG
        printf("%lx: %s: read %u bytes, error %d, blkno=0x%llx(0x%llx), %p\n",

<Prev in Thread] Current Thread [Next in Thread>