xfs
[Top] [All Lists]

Re: [PATCH RFC] xfs: set block device logical sector size on xfs_buftarg

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH RFC] xfs: set block device logical sector size on xfs_buftarg
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 14 Nov 2013 08:56:04 -0600
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131114133749.GA26268@xxxxxxxxxxxxx>
References: <5283C41D.7070503@xxxxxxxxxx> <20131113185645.GA20869@xxxxxxxxxxxxx> <5283CE2E.2070702@xxxxxxxxxxx> <20131113212658.GJ6188@dastard> <20131114133749.GA26268@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 11/14/13, 7:37 AM, Christoph Hellwig wrote:
> On Thu, Nov 14, 2013 at 08:26:58AM +1100, Dave Chinner wrote:
>> Seems like that's the avenue for improvement here to me. i.e. expose
>> the correct values to the guest so it's mkfs does the right thing.
>> Or, alternatively, make qemu buffer non-aligned/sized IOs itself
>> internally.
> 
> I've implemented the support to expose these to the guest in qemu
> years ago.  But the problem remains that this is information which
> needs to be attached to the image, which can't really work with raw
> images, and no one has bother to implement the support to store it
> for say qcow2.
> 

Ok but once again - this is not a guest mkfs issue.  The reported
problem is that the guest cannot _boot_ in cache=none mode because
the bios attempts a 512-byte DIO.

Yes, this is all qemu's fault.   We can fight that in the court
of public opinion, I guess.

-Eric

<Prev in Thread] Current Thread [Next in Thread>