xfs
[Top] [All Lists]

Re: [PATCH] xfstest generic/280: wait for setquota to finish before umou

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfstest generic/280: wait for setquota to finish before umount
From: Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>
Date: Wed, 13 Nov 2013 12:04:02 +0400
Cc: Guangyu Sun <guangyu.sun@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1382637381-4847-1-git-send-email-guangyu.sun@xxxxxxxxxx>
References: <1382637381-4847-1-git-send-email-guangyu.sun@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131030 Thunderbird/17.0.10

On 10/24/2013 09:56 PM, Guangyu Sun wrote:
While running xfstest 280, we occasionally got such error:

   setquota: Cannot set quota for user 0 from kernel on
   /dev/mapper/xfstests-disk1: No such device
   setquota: Cannot write quota for 0 on /dev/mapper/xfstests-disk1: No such
   device

setquota calls syscall quotactl, and the kernel will wait for the filesystem
to unfreeze and then performs command. Then kernel will double check if the
device is still mounted. If not, an ENODEV will be thrown.

While in the testcase, unfreeze and umount might be so close that the device
got umounted before quotactl is performed.

Reported-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>
Signed-off-by: Guangyu Sun <guangyu.sun@xxxxxxxxxx>
---
  tests/generic/280 |    1 +
  1 file changed, 1 insertion(+)
Hi!

Could anybody review this?

Thanks.

<Prev in Thread] Current Thread [Next in Thread>