Re: [PATCH] xfstest generic/280: wait for setquota to finish before umount

[Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>]

On 10/24/2013 09:56 PM, Guangyu Sun wrote:
> While running xfstest 280, we occasionally got such error:
>
>    setquota: Cannot set quota for user 0 from kernel on
>    /dev/mapper/xfstests-disk1: No such device
>    setquota: Cannot write quota for 0 on /dev/mapper/xfstests-disk1: No such
>    device
>
> setquota calls syscall quotactl, and the kernel will wait for the filesystem
> to unfreeze and then performs command. Then kernel will double check if the
> device is still mounted. If not, an ENODEV will be thrown.
>
> While in the testcase, unfreeze and umount might be so close that the device
> got umounted before quotactl is performed.
>
> Reported-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>
> Signed-off-by: Guangyu Sun <guangyu.sun@xxxxxxxxxx>
> ---
>   tests/generic/280 |    1 +
>   1 file changed, 1 insertion(+)
Hi!

Could anybody review this?

Thanks.