xfs
[Top] [All Lists]

Re: [PATCH] xfststs: add a helper to get the minimum dio size

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfststs: add a helper to get the minimum dio size
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 12 Nov 2013 12:32:32 -0600
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131112183031.GA8106@xxxxxxxxxxxxx>
References: <20131106105932.GA7807@xxxxxxxxxxxxx> <52826FBC.4000003@xxxxxxxxxxx> <20131112183031.GA8106@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 11/12/13, 12:30 PM, Christoph Hellwig wrote:
> On Tue, Nov 12, 2013 at 12:13:16PM -0600, Eric Sandeen wrote:
>> On 11/6/13, 4:59 AM, Christoph Hellwig wrote:
>>> Various tests opencode checks to find out the minimum support direct I/O
>>> size.  Replace those with a generic helper that handles network filesystems 
>>> as
>>> well.  Also remove the Linux 2.4 workaround we had in once place.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>>
>> No callers of min_dio_alignment w/o a blockdev right?  But I guess
>> that fallback is harmless.
> 
> All network filesystems will not have a device here.  Not sure how the
> btrfs pool names work, but that would be another suspect.
> 

Ah, sure.  So when running on NFS the blkdev is unset.  Wasn't thinking
about it that way, thanks.

-Eric

<Prev in Thread] Current Thread [Next in Thread>