xfs
[Top] [All Lists]

Re: [PATCH] xfststs: add a helper to get the minimum dio size

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfststs: add a helper to get the minimum dio size
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 12 Nov 2013 10:30:31 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52826FBC.4000003@xxxxxxxxxxx>
References: <20131106105932.GA7807@xxxxxxxxxxxxx> <52826FBC.4000003@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 12, 2013 at 12:13:16PM -0600, Eric Sandeen wrote:
> On 11/6/13, 4:59 AM, Christoph Hellwig wrote:
> > Various tests opencode checks to find out the minimum support direct I/O
> > size.  Replace those with a generic helper that handles network filesystems 
> > as
> > well.  Also remove the Linux 2.4 workaround we had in once place.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> No callers of min_dio_alignment w/o a blockdev right?  But I guess
> that fallback is harmless.

All network filesystems will not have a device here.  Not sure how the
btrfs pool names work, but that would be another suspect.

<Prev in Thread] Current Thread [Next in Thread>