xfs
[Top] [All Lists]

Re: [PATCH] xfstests: stop special casing nfs and udf

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH] xfstests: stop special casing nfs and udf
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 12 Nov 2013 12:23:53 -0600
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52827113.3080609@xxxxxxxxxxx>
References: <20131107204635.GA22954@xxxxxxxxxxxxx> <52827113.3080609@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 11/12/13, 12:18 PM, Eric Sandeen wrote:
> On 11/7/13, 2:46 PM, Christoph Hellwig wrote:
>> For historical reasons beyond my knowledge xfstests tries to abuse the
>> scratch device as test device for nfs and udf.  Because not all test
>> have inherited the right usage of the _setup_testdir and _cleanup_testdir
>> helpers this leads to lots of unessecary test failures.
>>
>> Remove the special casing, which gets nfs down to a minimal number of
>> failures.
>>
>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> 
> Oof, that was a lot of cruft.  Were you able to run UDF tests with
> these changes?  I wonder if Jan is using this for UDF?
> 
> (I don't have the UDF verifier that many(/all?) of the UDF tests
> require).

(Should have cc'd Jan, done now)

> -Eric

<Prev in Thread] Current Thread [Next in Thread>