xfs
[Top] [All Lists]

Re: [PATCH v4] xfs: fix unlock in xfs_bmap_add_attrfork

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH v4] xfs: fix unlock in xfs_bmap_add_attrfork
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 12 Nov 2013 09:36:56 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131107204358.901127238@.sgi.com>
References: <20131107204358.901127238@.sgi.com>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 07, 2013 at 03:43:28PM -0600, Mark Tinguely wrote:
> xfs_trans_ijoin() activates the inode in a transaction and
> also can specify which lock to free when the transaction is
> committed or canceled.
> 
> xfs_bmap_add_attrfork call locks and adds the lock to the
> transaction but also manually removes the lock. Change the
> routine to not add the lock to the transaction and manually
> remove lock on completion.
> 
> While here, clean up the xfs_trans_cancel flags and goto names.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>