Re: [PATCH v4] xfs: fix unlock in xfs_bmap_add_attrfork

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Nov 07, 2013 at 03:43:28PM -0600, Mark Tinguely wrote:
> xfs_trans_ijoin() activates the inode in a transaction and
> also can specify which lock to free when the transaction is
> committed or canceled.
> 
> xfs_bmap_add_attrfork call locks and adds the lock to the
> transaction but also manually removes the lock. Change the
> routine to not add the lock to the transaction and manually
> remove lock on completion.
> 
> While here, clean up the xfs_trans_cancel flags and goto names.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>