xfs
[Top] [All Lists]

[PATCH] xfs_repair: suggest reboot after dangerous repair

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfs_repair: suggest reboot after dangerous repair
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Tue, 12 Nov 2013 11:14:46 -0600
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
If a "dangerous" repair (repair of a readonly mounted fs)
has been done, suggest an immediate reboot upon completion.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

TBH, I don't know how "dangerous" dangerous is.  Is this
still required?

diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
index 820e7a2..9e1a774 100644
--- a/repair/xfs_repair.c
+++ b/repair/xfs_repair.c
@@ -884,6 +884,11 @@ _("Note - stripe unit (%d) and width (%d) fields have been 
reset.\n"
        if (verbose)
                summary_report();
        do_log(_("done\n"));
+
+       if (dangerously && !no_modify)
+               do_warn(
+_("Repair of readonly mount complete.  Immediate reboot encouraged.\n"));
+
        pftrace_done();
 
        return (0);

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfs_repair: suggest reboot after dangerous repair, Eric Sandeen <=