xfs
[Top] [All Lists]

[PATCH RFC] xfsprogs: suggest "-d" option for repair of RO mount

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH RFC] xfsprogs: suggest "-d" option for repair of RO mount
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Tue, 12 Nov 2013 11:13:17 -0600
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
How dangerous is dangerous?

We could offer the suggestion of a "-d" repair, if we're
in single-user mode with the root fs mounted readonly.

This change suggests -d to repair any RO mounted fs.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

diff --git a/repair/init.c b/repair/init.c
index c3f380b..a7a7613 100644
--- a/repair/init.c
+++ b/repair/init.c
@@ -97,8 +97,17 @@ xfs_init(libxfs_init_t *args)
        else
                args->isreadonly = LIBXFS_EXCLUSIVELY;
 
-       if (!libxfs_init(args))
+       if (!libxfs_init(args)) {
+               /* would -d be an option? */
+               if (!no_modify && !dangerously) {
+                       args->isreadonly = (LIBXFS_ISINACTIVE |
+                                           LIBXFS_DANGEROUSLY);
+                       if (libxfs_init(args))
+                               fprintf(stderr,
+_("Unmount or use -d to repair a read-only mounted filesystem\n"));
+               }
                do_error(_("couldn't initialize XFS library\n"));
+       }
 
        ts_create();
        increase_rlimit();

<Prev in Thread] Current Thread [Next in Thread>