xfs
[Top] [All Lists]

[PATCH v2] xfstests: _filter_mkfs should consume input from stdin for no

To: xfs@xxxxxxxxxxx
Subject: [PATCH v2] xfstests: _filter_mkfs should consume input from stdin for non-xfs fs
From: Eryu Guan <eguan@xxxxxxxxxx>
Date: Tue, 12 Nov 2013 15:59:18 +0800
Cc: Eryu Guan <eguan@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
_filter_mkfs is a filter so that it should read from stdin first
before printing anything out. Otherwise the command prior to the
pipeline may get EPIPE.

I saw this when testing extN with generic/204, _scratch_mkfs_sized was
unable to create fs because of EPIPE, then _scratch_mount failed.

generic/204 12s ... [failed, exit status 1] - output mismatch (see 
/root/xfstests/results//generic/204.out.bad)
    --- tests/generic/204.out   2013-11-01 16:47:56.728591856 +0800
    +++ /root/xfstests/results//generic/204.out.bad     2013-11-01 
22:52:53.207828779 +0800
    @@ -1,2 +1,7 @@
     QA output created by 204
    -*** done
    +mount: wrong fs type, bad option, bad superblock on /dev/sda6,
    +       missing codepage or helper program, or other error
    +       In some cases useful info is found in syslog - try
    +       dmesg | tail  or so
    +

Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
---
v2: just pipe stdin to /dev/null for non-xfs fs as Dave suggested.

 common/filter | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/filter b/common/filter
index e37ce69..c872a27 100644
--- a/common/filter
+++ b/common/filter
@@ -138,6 +138,7 @@ _filter_mkfs()
     xfs)
        ;;
     *)
+       cat - >/dev/null
        perl -e 'print STDERR "dbsize=4096\nisize=256\n"'
        return ;;
     esac
-- 
1.8.3.1

<Prev in Thread] Current Thread [Next in Thread>