xfs
[Top] [All Lists]

Re: [PATCH RESEND] xfstests: _filter_mkfs should consume input from stdi

To: Eryu Guan <eguan@xxxxxxxxxx>
Subject: Re: [PATCH RESEND] xfstests: _filter_mkfs should consume input from stdin first to avoid EPIPE
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 12 Nov 2013 15:55:05 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1384229874-30656-1-git-send-email-eguan@xxxxxxxxxx>
References: <1384229874-30656-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 12, 2013 at 12:17:54PM +0800, Eryu Guan wrote:
> _filter_mkfs is a filter so that it should read from stdin first
> before printing anything out. Otherwise the command prior to the
> pipeline may get EPIPE.
> 
> I saw this when testing extN with generic/204, _scratch_mkfs_sized was
> unable to create fs because of EPIPE, then _scratch_mount failed.

Ok, so that's a problem for filesystem types that don't actually
filter the output.

> generic/204 12s ... [failed, exit status 1] - output mismatch (see 
> /root/xfstests/results//generic/204.out.bad)
>     --- tests/generic/204.out   2013-11-01 16:47:56.728591856 +0800
>     +++ /root/xfstests/results//generic/204.out.bad     2013-11-01 
> 22:52:53.207828779 +0800
>     @@ -1,2 +1,7 @@
>      QA output created by 204
>     -*** done
>     +mount: wrong fs type, bad option, bad superblock on /dev/sda6,
>     +       missing codepage or helper program, or other error
>     +       In some cases useful info is found in syslog - try
>     +       dmesg | tail  or so
>     +
> 
> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
> ---
>  common/filter | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/common/filter b/common/filter
> index e37ce69..faf33e3 100644
> --- a/common/filter
> +++ b/common/filter
> @@ -134,16 +134,19 @@ _filter_date()
>  # Non XFS filesystems always return a 4k block size and a 256 byte inode.
>  _filter_mkfs()
>  {
> +    local tmp=/tmp/mkfs_filter
> +    cat - >$tmp
> +

tmp is a global scope variable, so shouldn't be used as a local lik
ethis. Indeed, a file is not needed at all here, because

>      case $FSTYP in
>      xfs)
>       ;;
>      *)
>       perl -e 'print STDERR "dbsize=4096\nisize=256\n"'
> +     rm -f $tmp
>       return ;;

for filesystems that don't consume stdin, you could just pipe it to
/dev/null here.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>