xfs
[Top] [All Lists]

Re: [PATCH] xfstests: generic/273: use src/feature -o

To: Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfstests: generic/273: use src/feature -o
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Mon, 11 Nov 2013 19:10:43 +0800
Cc: vasily.isaenko@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1384162494-17002-1-git-send-email-stanislav.kholmanskikh@xxxxxxxxxx>
References: <20131024010929.GR2797@dastard> <1384162494-17002-1-git-send-email-stanislav.kholmanskikh@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 11/11, 2013 17:34 PM, Stanislav Kholmanskikh wrote:
> Due to partially committed series (fd080d64b6e9677cb9d0a15dc7e308b6ca0e273f)
> generic/273 test uses '_no_of_online_cpus' function which is not defined.
> 
> Now it's safe to switch it to 'src/feature -o'.
> 
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>
> ---
>  tests/generic/273 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/generic/273 b/tests/generic/273
> index c028438..ab04dfa 100755
> --- a/tests/generic/273
> +++ b/tests/generic/273
> @@ -47,7 +47,7 @@ count=2
>  
>  _threads_set()
>  {
> -     _cpu_num=`_no_of_online_cpus`
> +     _cpu_num=`$here/src/feature -o`
>       threads=$(($_cpu_num * 50))
>       if [ $threads -gt 200 ]
>       then
Looks good to me.
Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>

Thanks,
-Jeff

<Prev in Thread] Current Thread [Next in Thread>