[Top] [All Lists]

Re: xfstest failures

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfstest failures
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 11 Nov 2013 07:33:31 +1100
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131107132739.GA16608@xxxxxxxxxxxxx>
References: <20131106105451.GA31283@xxxxxxxxxxxxx> <20131106161825.GU1935@xxxxxxx> <527A887F.2030807@xxxxxxxxxxx> <20131107081710.GC25157@xxxxxxxxxxxxx> <527B948C.9060905@xxxxxxxxxxx> <20131107132739.GA16608@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Nov 07, 2013 at 05:27:39AM -0800, Christoph Hellwig wrote:
> On Thu, Nov 07, 2013 at 07:24:28AM -0600, Eric Sandeen wrote:
> > On 11/7/13, 2:17 AM, Christoph Hellwig wrote:
> > > On Wed, Nov 06, 2013 at 12:20:47PM -0600, Eric Sandeen wrote:
> > >> that's right, it's a known bug w/ a testcase but no fix yet.
> > >>
> > >> I looked a bit, but ugh, xfsdump.
> > > 
> > > Maybe it's time you come up with an xfail mechanism at least?
> > 
> > What's the proposal there, a "fail" group for things known to still
> > fail everywhere?
> > 
> > so i.e. ./check -x fail ?  I can easily send a patch for that if
> > that's what folks want.
> A mechnism to annotate a test as xfail, so that check would output them
> at the end ala:
> Expected failures:  common/263
> Unexpected successes: reiser4/001

If you have a test that fails in your test environment and you don't
want to run it, use the expunged test mechanism. You can maintain it
yourself for your own test environment.

$ cat tests/xfs/expunged
$ sudo MKFS_OPTIONS="-m crc=1" ./check -X expunged xfs/078
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 test2 3.12.0-rc7-dgc+
MKFS_OPTIONS  -- -f -m crc=1 /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/scratch

xfs/078       [expunged]
Passed all 0 tests

If we really want to, we can add default expunged files for
different distros so they don't run tests that are known to fail and
are not likely to be fixed automatically.

That handles the "test doesn't fail everywhere" problem that xfail


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>