xfs
[Top] [All Lists]

Re: [PATCH 31/37] db: Unwind the IO stack on exit

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 31/37] db: Unwind the IO stack on exit
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 7 Nov 2013 12:55:58 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383700043-32305-32-git-send-email-david@xxxxxxxxxxxxx>
References: <1383700043-32305-1-git-send-email-david@xxxxxxxxxxxxx> <1383700043-32305-32-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 06, 2013 at 12:07:17PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_db can build up a large IO stack by the time it has run to
> completion. If we don't unwind this IO stack before we shut down the
> libxfs caches, metadump and other db programs will exit with
> unreleased buffers and emit warnings like:
> 
> cache_purge: shake on cache 0x69e4f0 left 7 nodes!?
> 
> Hence we need to unwind the iostack as we shut down.

Seems like this should be folded into patch 20, as that adds the
first pop, but it seems to fail goind all the way.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>