Re: [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 7 Nov 2013 12:51:08 -0800
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1383700043-32305-20-git-send-email-david@xxxxxxxxxxxxx>
References:	<1383700043-32305-1-git-send-email-david@xxxxxxxxxxxxx> <1383700043-32305-20-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Nov 06, 2013 at 12:07:05PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_db requires low level read/write buffer primitives that are the
> equivalent of libxfs_readbufr/writebufr. The implementation of
> libxfs_writebufr already handles discontiguous buffers, but there is
> no equivalent libxfs_readbufr_map support in the code.
> 
> Refactor libxfs_readbuf_map into two parts - one that does the
> buffer cache lookup, and the other that does the read IO. This
> provides the implementation of libxfs_readbufr_map that is required
> for xfs_db.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, (continued) Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Dave Chinner Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Christoph Hellwig [PATCH 21/37] db: introduce verifier support into set_cur, Dave Chinner [PATCH 35/37] repair: prefetching is turned off unnecessarily, Dave Chinner Re: [PATCH 35/37] repair: prefetching is turned off unnecessarily, Christoph Hellwig [PATCH 27/37] db: re-enable write support for v5 filesystems., Dave Chinner [PATCH 23/37] db: verify and calculate inode CRCs, Dave Chinner [PATCH 30/37] libxfs: work around do_div() not handling 32 bit numerators, Dave Chinner Re: [PATCH 30/37] libxfs: work around do_div() not handling 32 bit numerators, Christoph Hellwig [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db, Dave Chinner Re: [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db, Christoph Hellwig <= [PATCH 28/37] xfs_db: avoid libxfs buffer lookup warnings, Dave Chinner Re: [PATCH 28/37] xfs_db: avoid libxfs buffer lookup warnings, Dave Chinner Re: [PATCH 28/37] xfs_db: avoid libxfs buffer lookup warnings, Christoph Hellwig [PATCH 31/37] db: Unwind the IO stack on exit, Dave Chinner Re: [PATCH 31/37] db: Unwind the IO stack on exit, Christoph Hellwig [PATCH 25/37] db: add a special directory buffer verifier, Dave Chinner [PATCH 22/37] db: indicate if the CRC on a buffer is correct or not, Dave Chinner [PATCH 18/37] db: rewrite bbmap to use xfs_buf_map, Dave Chinner [PATCH 16/37] libxfs: stop caching inode structures, Dave Chinner [PATCH 13/37] xfs: fix node forward in xfs_node_toosmall, Dave Chinner

Previous by Date:	Re: [PATCH 17/37] db: separate out straight buffer IO from map based IO., Christoph Hellwig
Next by Date:	Re: [PATCH 28/37] xfs_db: avoid libxfs buffer lookup warnings, Christoph Hellwig
Previous by Thread:	[PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db, Dave Chinner
Next by Thread:	[PATCH 28/37] xfs_db: avoid libxfs buffer lookup warnings, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db