xfs
[Top] [All Lists]

Re: [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 7 Nov 2013 12:51:08 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383700043-32305-20-git-send-email-david@xxxxxxxxxxxxx>
References: <1383700043-32305-1-git-send-email-david@xxxxxxxxxxxxx> <1383700043-32305-20-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 06, 2013 at 12:07:05PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_db requires low level read/write buffer primitives that are the
> equivalent of libxfs_readbufr/writebufr. The implementation of
> libxfs_writebufr already handles discontiguous buffers, but there is
> no equivalent libxfs_readbufr_map support in the code.
> 
> Refactor libxfs_readbuf_map into two parts - one that does the
> buffer cache lookup, and the other that does the read IO. This
> provides the implementation of libxfs_readbufr_map that is required
> for xfs_db.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>