Re: [PATCH] xfsdump: don't assume getdents exists

[Kyle McMartin <kmcmarti@xxxxxxxxxx>]

On Thu, Nov 07, 2013 at 10:17:13AM +1100, Dave Chinner wrote:
> > I'll try to clean it up and send a patch for that, using getdents64
> > wherever possible, and handling the fallback at runtime instead of
> > making things all ifdeffy... Just wanted to get things building in the
> > mean time. (Oh man the coding style there is janky...)
> 
> I'd factor and reformat the code using the normal kernel style. :)
> 
> And to avoid ifdef hackery and runtime fallbacks, I'd add an
> autoconf macro to determine which getdents call is supported, and
> then only compile in the relevant function and not have to care
> about runtime fallbacks.
> 
> But that may end up more complex and more work than you had in mind,
> so feel free to ignore my suggestions ;)
> 

Good thinking... I'll poke at it.

Thanks Dave!

Kyle