Re: [PATCH 36/37] repair: Increase default repair parallelism on large f

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Thu, 7 Nov 2013 06:13:45 +1100
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20131106104111.GB21067@xxxxxxxxxxxxx>
References:	<1383700043-32305-1-git-send-email-david@xxxxxxxxxxxxx> <1383700043-32305-37-git-send-email-david@xxxxxxxxxxxxx> <20131106104111.GB21067@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Nov 06, 2013 at 02:41:11AM -0800, Christoph Hellwig wrote:
> On Wed, Nov 06, 2013 at 12:07:22PM +1100, Dave Chinner wrote:
> > +   if (!ag_stride && glob_agcount >= 16 && do_prefetch)
> > +           ag_stride = 15;
> 
> Shouldn't we have a define for the agcount shared by mkfs and repair, and
> derive the stride from it?
> 
> Otherwise looks fine.

Yes, we could.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 26/37] db: add a special attribute buffer verifier, (continued) [PATCH 26/37] db: add a special attribute buffer verifier, Dave Chinner [PATCH 03/37] xfs: create a shared header file for format-related information, Dave Chinner [PATCH 20/37] db: rewrite IO engine to use libxfs, Dave Chinner [PATCH 37/37] repair: fix leaf node directory data check, Dave Chinner Re: [PATCH 37/37] repair: fix leaf node directory data check, Christoph Hellwig [PATCH 17/37] db: separate out straight buffer IO from map based IO., Dave Chinner Re: [PATCH 17/37] db: separate out straight buffer IO from map based IO., Christoph Hellwig [PATCH 32/37] db: enable metadump on CRC filesystems, Dave Chinner [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Dave Chinner Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Christoph Hellwig Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Dave Chinner <= Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Dave Chinner Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Christoph Hellwig [PATCH 21/37] db: introduce verifier support into set_cur, Dave Chinner [PATCH 35/37] repair: prefetching is turned off unnecessarily, Dave Chinner Re: [PATCH 35/37] repair: prefetching is turned off unnecessarily, Christoph Hellwig [PATCH 27/37] db: re-enable write support for v5 filesystems., Dave Chinner [PATCH 23/37] db: verify and calculate inode CRCs, Dave Chinner [PATCH 30/37] libxfs: work around do_div() not handling 32 bit numerators, Dave Chinner Re: [PATCH 30/37] libxfs: work around do_div() not handling 32 bit numerators, Christoph Hellwig [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db, Dave Chinner

Previous by Date:	Re: xfstest failures, Eric Sandeen
Next by Date:	Re: [PATCH 00/37 V4] xfsprogs: CRC write support for xfs_db + more, Dave Chinner
Previous by Thread:	Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Christoph Hellwig
Next by Thread:	Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]