xfs
[Top] [All Lists]

Re: [PATCH 36/37] repair: Increase default repair parallelism on large f

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 7 Nov 2013 06:13:45 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131106104111.GB21067@xxxxxxxxxxxxx>
References: <1383700043-32305-1-git-send-email-david@xxxxxxxxxxxxx> <1383700043-32305-37-git-send-email-david@xxxxxxxxxxxxx> <20131106104111.GB21067@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 06, 2013 at 02:41:11AM -0800, Christoph Hellwig wrote:
> On Wed, Nov 06, 2013 at 12:07:22PM +1100, Dave Chinner wrote:
> > +   if (!ag_stride && glob_agcount >= 16 && do_prefetch)
> > +           ag_stride = 15;
> 
> Shouldn't we have a define for the agcount shared by mkfs and repair, and
> derive the stride from it?
> 
> Otherwise looks fine.

Yes, we could.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>