xfs
[Top] [All Lists]

Re: ***** SUSPECTED SPAM ***** [RFD 11/17] xfs: factor xfs_create to pre

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: ***** SUSPECTED SPAM ***** [RFD 11/17] xfs: factor xfs_create to prepare for O_TMPFILE
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Nov 2013 03:21:45 -0800
Cc: xfs@xxxxxxxxxxx, Zhi Yong Wu <zwu.kernel@xxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1376313607-28133-12-git-send-email-david@xxxxxxxxxxxxx>
References: <1376313607-28133-1-git-send-email-david@xxxxxxxxxxxxx> <1376313607-28133-12-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Aug 12, 2013 at 11:20:01PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> O_TMPFILE support requires allocating an inode that is not attached to the
> a current namespace - it's anonymous. The current inode allocation code runs
> through xfs_create() which requires a parent inode and a name to be passed to
> it. for O_TMPFILE, we do not have a parent inode or a name so we cannot use
> the same calling conventions as xfs_create() to allocate a inode.

Btw, O_TMPFILE does get a path passed, which the existing
implementations treat as an invisible parent.  I would suggest we follow
that path for our allocation decisions for now.

<Prev in Thread] Current Thread [Next in Thread>