xfs
[Top] [All Lists]

Re: [PATCH 36/37] repair: Increase default repair parallelism on large f

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Nov 2013 02:41:11 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383700043-32305-37-git-send-email-david@xxxxxxxxxxxxx>
References: <1383700043-32305-1-git-send-email-david@xxxxxxxxxxxxx> <1383700043-32305-37-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 06, 2013 at 12:07:22PM +1100, Dave Chinner wrote:
> +     if (!ag_stride && glob_agcount >= 16 && do_prefetch)
> +             ag_stride = 15;

Shouldn't we have a define for the agcount shared by mkfs and repair, and
derive the stride from it?

Otherwise looks fine.

<Prev in Thread] Current Thread [Next in Thread>