xfs
[Top] [All Lists]

Re: [PATCH 37/37] repair: fix leaf node directory data check

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 37/37] repair: fix leaf node directory data check
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Nov 2013 02:39:10 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383700043-32305-38-git-send-email-david@xxxxxxxxxxxxx>
References: <1383700043-32305-1-git-send-email-david@xxxxxxxxxxxxx> <1383700043-32305-38-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 06, 2013 at 12:07:23PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When walking the leaf node format blocks (LEAFN) in the hash index
> of a large directory, we could trip over btree node blocks (DA_NODE)
> in the address space if there are enough entries in the directory.
> These cause a verifier failure, and hence the directory is
> considered corrupt and is trashed and rebuilt unnecesarily. Fix this
> by using the correct verifier that can handle both types of blocks
> without triggering failures.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>