xfs
[Top] [All Lists]

Re: [PATCH 5/5] xfs: increase inode cluster size for v5 filesystems

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/5] xfs: increase inode cluster size for v5 filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 6 Nov 2013 06:56:50 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131105164307.GD32110@xxxxxxxxxxxxx>
References: <1383280040-21979-1-git-send-email-david@xxxxxxxxxxxxx> <1383280040-21979-6-git-send-email-david@xxxxxxxxxxxxx> <20131105164307.GD32110@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 05, 2013 at 08:43:07AM -0800, Christoph Hellwig wrote:
> > +   if (xfs_sb_version_hascrc(&mp->m_sb)) {
> > +           int     new_size = mp->m_inode_cluster_size;
> > +
> > +           new_size *= mp->m_sb.sb_inodesize / XFS_DINODE_MIN_SIZE;
> > +           if (mp->m_sb.sb_inoalignmt >= XFS_B_TO_FSBT(mp, new_size))
> > +                   mp->m_inode_cluster_size = new_size;
> > +           xfs_info(mp, "Using inode cluster size of %d bytes",
> > +                    mp->m_inode_cluster_size);
> 
> printing this on every mount seem a bit too verbose.

I'd like to leave it there until we remove the experimental tag from
the v5 superblock configuration, as there is no good way of
determining that someone is using a mkfs patched to enable this
feature yet...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>