xfs
[Top] [All Lists]

Re: [PATCH 28/30] db: enable metadump on CRC filesystems

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 28/30] db: enable metadump on CRC filesystems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 4 Nov 2013 01:18:28 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383107481-28937-29-git-send-email-david@xxxxxxxxxxxxx>
References: <1383107481-28937-1-git-send-email-david@xxxxxxxxxxxxx> <1383107481-28937-29-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 30, 2013 at 03:31:19PM +1100, Dave Chinner wrote:
> While there, add IO stack unwinding to xfs_db to prevent metadump
> and other db programs from exiting with unreleased buffers in the IO
> stack and hence emitting warnings like:
> 
> cache_purge: shake on cache 0x69e4f0 left 7 nodes!?

Seems like that should be a separate patch.


> @@ -202,7 +204,8 @@ close_devices:
>        * make sure that we pop the last buffer context we held so that the
>        * buffer is released before purge the caches during unmount.
>        */
> -     pop_cur();
> +     while (iocur_sp > start_iocur_sp)
> +             pop_cur();

The comment above this needs an update.


Otherwise looks fine.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 28/30] db: enable metadump on CRC filesystems, Christoph Hellwig <=