xfs
[Top] [All Lists]

Re: [PATCH 22/30] db: add a special directory buffer verifier

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 22/30] db: add a special directory buffer verifier
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 4 Nov 2013 01:07:16 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383107481-28937-23-git-send-email-david@xxxxxxxxxxxxx>
References: <1383107481-28937-1-git-send-email-david@xxxxxxxxxxxxx> <1383107481-28937-23-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 30, 2013 at 03:31:13PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Because we only have a single directory type that is used for all
> the different buffer types, we need to provide a special verifier
> for the read code. That verifier needs to know all the directory
> types and when it find one it knows about, switch to the correct
> verifier and call it.
> 
> We already do this for certain readahead cases in the directory
> code, so there is precedence for this. If we don't find a magic
> number we recognise, the verifier fails...
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 22/30] db: add a special directory buffer verifier, Christoph Hellwig <=