xfs
[Top] [All Lists]

Re: [PATCH 21/30] db: verify and calculate dquot CRCs

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 21/30] db: verify and calculate dquot CRCs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 4 Nov 2013 01:06:27 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383107481-28937-22-git-send-email-david@xxxxxxxxxxxxx>
References: <1383107481-28937-1-git-send-email-david@xxxxxxxxxxxxx> <1383107481-28937-22-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 30, 2013 at 03:31:12PM +1100, Dave Chinner wrote:
> When we set the current Io cursor to point at a dquot block, verify
> that the dquot CRC is intact. And prior to writing such an IO
> cursor, calculate the dquot CRC.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  db/io.c | 5 ++++-
>  db/io.h | 1 +
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/db/io.c b/db/io.c
> index 8ddb5e5..7281148 100644
> --- a/db/io.c
> +++ b/db/io.c
> @@ -464,7 +464,9 @@ write_cur(void)
>  
>       if (iocur_top->ino_buf)
>               libxfs_dinode_calc_crc(mp, iocur_top->data);
> -
> +     if (iocur_top->dquot_buf)
> +             xfs_update_cksum(iocur_top->data, sizeof(struct xfs_dqblk),
> +                              XFS_DQUOT_CRC_OFF);

The patch looks good to get going, but it seems we'd be better off going
through an ops vector here in some form..

<Prev in Thread] Current Thread [Next in Thread>