xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix possible NULL dereference

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] xfs: fix possible NULL dereference
From: Geyslan Gregório Bem <geyslan@xxxxxxxxx>
Date: Thu, 31 Oct 2013 14:15:57 -0200
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>, XFS FILESYSTEM <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=VhUMqQJdR6Mt6LRk2OW7f0cOMMU3J/xKsJerh5huj30=; b=xYj+0LCBRoyGxhXgm1X3B0yEYHnJPeyG02zTKtTBAnHliWupMAzFxOlF0xHVXmaZfS IBECXjAeH/8lN689oQnasjXlb7G6pwiIm8p47iK+R2wc0zVdgrih8PaLjB/MtM5T8fav b5GX2RutthJnILCoNBKqhMTtt3BrTofBiokARdl30YmA07Sa+EuaI1UtSvSo97NcSbDh uGukcQlrWEE3vx0sS5HDrjLCw7Ap8iuA+6m4UiFiNNR/kGuez90ark5P8Sr4ZD2kfW25 BHimMuFsEkOHbISp6zaMBKBIIGUBx9vTu8ZJeuf2XVOMOGzwvRYU3RKcql8lEzqrwuM5 UHOw==
In-reply-to: <20131031155503.GO1935@xxxxxxx>
References: <5265C03B.50701@xxxxxxxxxxx> <20131022001732.GI4446@dastard> <CAGG-pUTh-PJJ4Nzo0r-f3VDPMc81U2z_NMX+Wcex3KzGs=U8cA@xxxxxxxxxxxxxx> <20131022203946.GB2797@dastard> <5266E4BD.8030601@xxxxxxxxxxx> <20131022210300.GC2797@dastard> <5266EBF0.901@xxxxxxxxxxx> <CAGG-pUTtYomspBXn=RE7YFU=vu6rWZ1fU7CBO45Mmodj8DZFiQ@xxxxxxxxxxxxxx> <20131023203435.GR1935@xxxxxxx> <5271672C.7070101@xxxxxxxxxxx> <20131031155503.GO1935@xxxxxxx>
2013/10/31 Ben Myers <bpm@xxxxxxx>:
> Hey Geyslan,
>
> On Wed, Oct 30, 2013 at 03:08:12PM -0500, Eric Sandeen wrote:
>> On 10/23/13 3:34 PM, Ben Myers wrote:
>>
>> > xfs: fix possible NULL dereference in xlog_verify_iclog
>> >
>> > In xlog_verify_iclog a debug check of the incore log buffers prints an
>> > error if icptr is null and then goes on to dereference the pointer
>> > regardless.  Convert this to an assert so that the intention is clear.
>> > This was reported by Coverty.
>> >
>> > Reported-by: Geyslan G. Bem <geyslan@xxxxxxxxx>
>> > Signed-off-by: Ben Myers <bpm@xxxxxxx>
>>
>> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>
> Applied this.  Many thanks!  ;)
>
> -Ben

It was a pleasure. o/

-- 
Regards,

Geyslan G. Bem
hackingbits.com

<Prev in Thread] Current Thread [Next in Thread>