xfs
[Top] [All Lists]

Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

To: Denis Efremov <yefremov.denis@xxxxxxxxx>
Subject: Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 31 Oct 2013 10:56:03 -0500
Cc: ldv-project@xxxxxxxxxxxxxxxx, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131025150609.GB10553@xxxxxxx>
References: <20131022203322.GA2797@dastard> <1382702005-32245-1-git-send-email-yefremov.denis@xxxxxxxxx> <20131025150609.GB10553@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Oct 25, 2013 at 10:06:09AM -0500, Ben Myers wrote:
> On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote:
> > ASSERT on args takes place after args dereference.
> > This assertion is redundant since we are going to panic anyway.
> > 
> > Found by Linux Driver Verification project (linuxtesting.org) -
> > PVS-Studio analyzer.
> > 
> > Signed-off-by: Denis Efremov <yefremov.denis@xxxxxxxxx>
> 
> Looks good. 
> 
> Reviewed-by: Ben Myers <bpm@xxxxxxx>

Applied.  Thanks Denis.

<Prev in Thread] Current Thread [Next in Thread>