xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix possible NULL dereference

To: Geyslan Gregório Bem <geyslan@xxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix possible NULL dereference
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 31 Oct 2013 10:55:03 -0500
Cc: Alex Elder <elder@xxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>, XFS FILESYSTEM <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5271672C.7070101@xxxxxxxxxxx>
References: <5265C03B.50701@xxxxxxxxxxx> <20131022001732.GI4446@dastard> <CAGG-pUTh-PJJ4Nzo0r-f3VDPMc81U2z_NMX+Wcex3KzGs=U8cA@xxxxxxxxxxxxxx> <20131022203946.GB2797@dastard> <5266E4BD.8030601@xxxxxxxxxxx> <20131022210300.GC2797@dastard> <5266EBF0.901@xxxxxxxxxxx> <CAGG-pUTtYomspBXn=RE7YFU=vu6rWZ1fU7CBO45Mmodj8DZFiQ@xxxxxxxxxxxxxx> <20131023203435.GR1935@xxxxxxx> <5271672C.7070101@xxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Geyslan,

On Wed, Oct 30, 2013 at 03:08:12PM -0500, Eric Sandeen wrote:
> On 10/23/13 3:34 PM, Ben Myers wrote:
> 
> > xfs: fix possible NULL dereference in xlog_verify_iclog
> > 
> > In xlog_verify_iclog a debug check of the incore log buffers prints an
> > error if icptr is null and then goes on to dereference the pointer
> > regardless.  Convert this to an assert so that the intention is clear.
> > This was reported by Coverty.
> > 
> > Reported-by: Geyslan G. Bem <geyslan@xxxxxxxxx>
> > Signed-off-by: Ben Myers <bpm@xxxxxxx>
> 
> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Applied this.  Many thanks!  ;)

-Ben

<Prev in Thread] Current Thread [Next in Thread>