xfs
[Top] [All Lists]

Re: [PATCH 11/30] xfs: remove newlines from strings passed to __xfs_prin

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/30] xfs: remove newlines from strings passed to __xfs_printk
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 31 Oct 2013 07:49:10 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383107481-28937-12-git-send-email-david@xxxxxxxxxxxxx>
References: <1383107481-28937-1-git-send-email-david@xxxxxxxxxxxxx> <1383107481-28937-12-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 30, 2013 at 03:31:02PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> __xfs_printk adds its own "\n".  Having it in the original string
> leads to unintentional blank lines from these messages.
> 
> Ported from kernel commit 08e96e1a.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>