xfs
[Top] [All Lists]

Re: [PATCH 07/30] libxfs: bmap btree owner swap support

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/30] libxfs: bmap btree owner swap support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 31 Oct 2013 07:47:39 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383107481-28937-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1383107481-28937-1-git-send-email-david@xxxxxxxxxxxxx> <1383107481-28937-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 30, 2013 at 03:30:58PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> For CRC enabled filesystems, we can't just swap inode forks from one
> inode to another when defragmenting a file - the blocks in the inode
> fork bmap btree contain pointers back to the owner inode. Hence if
> we are to swap the inode forks we have to atomically modify every
> block in the btree during the transaction.
> 
> This patch brings across the kernel code for doing the owner
> swap of an entire fork - something that we are likely to end up
> needing in xfs_repair when reparenting stray inodes to lost+found -
> without all the associated swap extents transaction and recovery
> cruft as those parts are not needed in userspace.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>