xfs
[Top] [All Lists]

Re: [PATCH 06/30] libxfs: unify xfs_btree.c with kernel code

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/30] libxfs: unify xfs_btree.c with kernel code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 31 Oct 2013 07:46:23 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383107481-28937-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1383107481-28937-1-git-send-email-david@xxxxxxxxxxxxx> <1383107481-28937-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 30, 2013 at 03:30:57PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The libxfs/xfs_btree.c code does not contain a small amount of code
> for btree block readahead that the kernel code does. Instead, it
> short circuits it at a higher layer and doesn't include the lower
> layer functions. There is no harm in calling the lower lay functions
> and have them do nothing, and doing so unifies the kernel and
> userspace code.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>