xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix compile error of src/fssum.c on bigendian host

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfstests: fix compile error of src/fssum.c on bigendian host
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Thu, 31 Oct 2013 10:12:54 -0200
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383105343-15348-1-git-send-email-eguan@xxxxxxxxxx>
Mail-followup-to: xfs@xxxxxxxxxxx
References: <1383105343-15348-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Looks good,

Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
On Wed, Oct 30, 2013 at 11:55:43AM +0800, Eryu Guan wrote:
> Definition of htonll() is needed on bigendian host too, otherwise
> src/fssum.c won't compile on ppc64/s390x hosts.
> 
> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
> ---
>  src/fssum.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/fssum.c b/src/fssum.c
> index c75ff8b..c26d32b 100644
> --- a/src/fssum.c
> +++ b/src/fssum.c
> @@ -50,6 +50,8 @@
>  
>  #if __BYTE_ORDER == __LITTLE_ENDIAN
>  #define htonll(x)     __bswap_64 (x)
> +#else
> +#define htonll(x)     (x)
>  #endif
>  #endif
>  
> -- 
> 1.8.3.1
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

<Prev in Thread] Current Thread [Next in Thread>