xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix compile error of src/fssum.c on bigendian host

To: Eryu Guan <eguan@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix compile error of src/fssum.c on bigendian host
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 30 Oct 2013 15:21:34 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383105343-15348-1-git-send-email-eguan@xxxxxxxxxx>
References: <1383105343-15348-1-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 30, 2013 at 11:55:43AM +0800, Eryu Guan wrote:
> Definition of htonll() is needed on bigendian host too, otherwise
> src/fssum.c won't compile on ppc64/s390x hosts.
> 
> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
> ---
>  src/fssum.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/fssum.c b/src/fssum.c
> index c75ff8b..c26d32b 100644
> --- a/src/fssum.c
> +++ b/src/fssum.c
> @@ -50,6 +50,8 @@
>  
>  #if __BYTE_ORDER == __LITTLE_ENDIAN
>  #define htonll(x)     __bswap_64 (x)
> +#else
> +#define htonll(x)     (x)
>  #endif
>  #endif

Looks fine.

Acked-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>