xfs
[Top] [All Lists]

Re: [PATCH 13/15] xfs: validity check the directory block leaf entry cou

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 13/15] xfs: validity check the directory block leaf entry count
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 29 Oct 2013 15:43:19 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1383045118-31107-14-git-send-email-david@xxxxxxxxxxxxx>
References: <1383045118-31107-1-git-send-email-david@xxxxxxxxxxxxx> <1383045118-31107-14-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Oct 29, 2013 at 10:11:56PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The directory block format verifier fails to check that the leaf
> entry count is in a valid range, and so if it is corrupted then it
> can lead to derefencing a pointer outside the block buffer. While we
> can't exactly validate the count without first walking the directory
> block, we can ensure the count lands in the valid area within the
> directory block and hence avoid out-of-block references.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks fine.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>