xfs
[Top] [All Lists]

Re: [PATCH 16/19] xfs: vectorise DA btree operations

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 16/19] xfs: vectorise DA btree operations
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 25 Oct 2013 12:17:09 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1381789085-21923-17-git-send-email-david@xxxxxxxxxxxxx>
References: <1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-17-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Oct 15, 2013 at 09:18:02AM +1100, Dave Chinner wrote:
> The remaining non-vectorised code for the directory structure is the
> node format blocks. This is shared with the attribute tree, and so
> is slightly more complex to vectorise.
> 
> Introduce a "non-directory" directory ops structure that is attached
> to all non-directory inodes so that attribute operations can be
> vectorised for all inodes.
> 
> Once we do this, we can vectorise all the da btree operations.
> Because this patch adds more infrastructure than it removes the
> binary size does not decrease:
> 
>    text    data     bss     dec     hex filename
>  794490   96802    1096  892388   d9de4 fs/xfs/xfs.o.orig
>  792986   96802    1096  890884   d9804 fs/xfs/xfs.o.p1
>  792350   96802    1096  890248   d9588 fs/xfs/xfs.o.p2
>  789293   96802    1096  887191   d8997 fs/xfs/xfs.o.p3
>  789005   96802    1096  886903   d8997 fs/xfs/xfs.o.p4
>  789061   96802    1096  886959   d88af fs/xfs/xfs.o.p5
>  789733   96802    1096  887631   d8b4f fs/xfs/xfs.o.p6
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>