xfs
[Top] [All Lists]

Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

To: Denis Efremov <yefremov.denis@xxxxxxxxx>
Subject: Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 25 Oct 2013 10:06:09 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ldv-project@xxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1382702005-32245-1-git-send-email-yefremov.denis@xxxxxxxxx>
References: <20131022203322.GA2797@dastard> <1382702005-32245-1-git-send-email-yefremov.denis@xxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote:
> ASSERT on args takes place after args dereference.
> This assertion is redundant since we are going to panic anyway.
> 
> Found by Linux Driver Verification project (linuxtesting.org) -
> PVS-Studio analyzer.
> 
> Signed-off-by: Denis Efremov <yefremov.denis@xxxxxxxxx>

Looks good. 

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>