Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

xfs

Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

To:	Denis Efremov <yefremov.denis@xxxxxxxxx>
Subject:	Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null
From:	Ben Myers <bpm@xxxxxxx>
Date:	Fri, 25 Oct 2013 10:06:09 -0500
Cc:	Dave Chinner <david@xxxxxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ldv-project@xxxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1382702005-32245-1-git-send-email-yefremov.denis@xxxxxxxxx>
References:	<20131022203322.GA2797@dastard> <1382702005-32245-1-git-send-email-yefremov.denis@xxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote:
> ASSERT on args takes place after args dereference.
> This assertion is redundant since we are going to panic anyway.
> 
> Found by Linux Driver Verification project (linuxtesting.org) -
> PVS-Studio analyzer.
> 
> Signed-off-by: Denis Efremov <yefremov.denis@xxxxxxxxx>

Looks good. 

Reviewed-by: Ben Myers <bpm@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs:xfs_dir2_node.c: pointer use before check for null, Denis Efremov Re: [PATCH] xfs:xfs_dir2_node.c: pointer use before check for null, Dave Chinner [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null, Denis Efremov Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null, Ben Myers <= Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null, Ben Myers

Previous by Date:	Re: Archive old patches on "Patchwork XFS Filesystem from SGI", Eric Sandeen
Next by Date:	Re: Aw: Re: xfs_repair segfaulting in phase 3, Eric Sandeen
Previous by Thread:	[PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null, Denis Efremov
Next by Thread:	Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null, Ben Myers
Indexes:	[Date] [Thread] [Top] [All Lists]