xfs
[Top] [All Lists]

[PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null
From: Denis Efremov <yefremov.denis@xxxxxxxxx>
Date: Fri, 25 Oct 2013 15:53:25 +0400
Cc: Denis Efremov <yefremov.denis@xxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ldv-project@xxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to; bh=5m64mf29Z3VcffXvhxlUnikEFn3CTfaPCA/CbD5Ov9I=; b=Rpsxr008SjPVs6Cmjam0iqMK7rOMC3QEGgcOZVp6UdtbJ4y8j9roI+Vt8Ami6HSnM3 1YpmqHTWJ0zwI4fMv1kqqsJ0rsZjszmhB1pyFXtvsdzTuN6Mw5KP7AhJQ1IlR0ZvuOQ9 NM37uQZUWvEZlYuNv3NNKqD0N3FPYLZ+HzCSFaxTQXhaKPTFMxbzs1zQCSYQ3nAmSrIC LbT0zSKYpWNJY9g0OQ14JEH+errB6bVWJASFAV2awjfG+iRw1q4PvYTFZO6lt5eVIpe+ yQvqoK/2XgfaF0UaZNOXyHtYXuSOT6K8rjvOPEUGqWnFMiwfYg9AgnScCYd0uekD8QYf fbtQ==
In-reply-to: <20131022203322.GA2797@dastard>
ASSERT on args takes place after args dereference.
This assertion is redundant since we are going to panic anyway.

Found by Linux Driver Verification project (linuxtesting.org) -
PVS-Studio analyzer.

Signed-off-by: Denis Efremov <yefremov.denis@xxxxxxxxx>
---
 fs/xfs/xfs_dir2_node.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_dir2_node.c b/fs/xfs/xfs_dir2_node.c
index 4c3dba7..dc814df 100644
--- a/fs/xfs/xfs_dir2_node.c
+++ b/fs/xfs/xfs_dir2_node.c
@@ -1366,7 +1366,6 @@ xfs_dir2_leafn_split(
         */
        args = state->args;
        mp = args->dp->i_mount;
-       ASSERT(args != NULL);
        ASSERT(oldblk->magic == XFS_DIR2_LEAFN_MAGIC);
        error = xfs_da_grow_inode(args, &blkno);
        if (error) {
-- 
1.8.3.1

<Prev in Thread] Current Thread [Next in Thread>