xfs
[Top] [All Lists]

Re: [PATCH] xfs: prevent stack overflows from page cache allocation

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: prevent stack overflows from page cache allocation
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 25 Oct 2013 04:29:34 -0700
Cc: Ben Myers <bpm@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131024212448.GW2797@dastard>
References: <1382585110-1796-1-git-send-email-david@xxxxxxxxxxxxx> <20131024084803.GA28144@xxxxxxxxxxxxx> <20131024103751.GS2797@dastard> <20131024154220.GA19055@xxxxxxxxxxxxx> <20131024164115.GU1935@xxxxxxx> <20131024212448.GW2797@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Oct 25, 2013 at 08:24:48AM +1100, Dave Chinner wrote:
> > > I'd much prefer aiming for the proper fix first.  If for some reason we
> > > can't get it done in time the workaround can be applied.
> > 
> > Dave probably has a customer waiting on this.
> 
> Obviously. And being a kernel where we have a fixed ABI, we can't
> backport any fix that changes core code.

No one is trying to tell you what to ship to your customers.  That
doesn't mean we should aim for the right fix upstream.

I don't really mind pushing patches like yours as a last resort when
dealing with unrepsonsive or disagreeing maintainers like we had to do
in the past, but trying to push the workaround without even attemping
the proper fix is a bit sad.

<Prev in Thread] Current Thread [Next in Thread>