xfs
[Top] [All Lists]

Re: [PATCH v3 4/4] xfsprog: add mkfs.xfs sb v4 support for dirent filety

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v3 4/4] xfsprog: add mkfs.xfs sb v4 support for dirent filetype field
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 24 Oct 2013 16:29:12 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131024211708.GU2797@dastard>
References: <20131017152804.204045257@xxxxxxx> <20131017152955.689963160@xxxxxxx> <20131024161514.GA14558@xxxxxxxxxxxxx> <20131024211708.GU2797@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 10/24/13 16:17, Dave Chinner wrote:
On Thu, Oct 24, 2013 at 09:15:14AM -0700, Christoph Hellwig wrote:
On Thu, Oct 17, 2013 at 10:28:08AM -0500, Mark Tinguely wrote:
Add directory inode type feature to mkfs.xfs and its manual page.

In sb v4, "mkfs.xfs -n ftype=1" turns on the feature.

The feature is automatically turned on for "-m crc=1", but reject
the use of the "-n ftype=0|1" with the "-m crc=1" option.

Seems like this causes a spurious failure in xfs/206:

Yes, it will. the xfstests repair filter needs to be updated every
time a new option is added to the output.

Cheers,

Dave.

Thanks for the heads up.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>