xfs
[Top] [All Lists]

Re: [PATCH v3 4/4] xfsprog: add mkfs.xfs sb v4 support for dirent filety

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v3 4/4] xfsprog: add mkfs.xfs sb v4 support for dirent filetype field
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 25 Oct 2013 08:17:08 +1100
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131024161514.GA14558@xxxxxxxxxxxxx>
References: <20131017152804.204045257@xxxxxxx> <20131017152955.689963160@xxxxxxx> <20131024161514.GA14558@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 24, 2013 at 09:15:14AM -0700, Christoph Hellwig wrote:
> On Thu, Oct 17, 2013 at 10:28:08AM -0500, Mark Tinguely wrote:
> > Add directory inode type feature to mkfs.xfs and its manual page.
> > 
> > In sb v4, "mkfs.xfs -n ftype=1" turns on the feature.
> > 
> > The feature is automatically turned on for "-m crc=1", but reject
> > the use of the "-n ftype=0|1" with the "-m crc=1" option.
> 
> Seems like this causes a spurious failure in xfs/206:

Yes, it will. the xfstests repair filter needs to be updated every
time a new option is added to the output.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>