xfs
[Top] [All Lists]

Re: xfstest 318

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfstest 318
From: Dwight Engen <dwight.engen@xxxxxxxxxx>
Date: Thu, 24 Oct 2013 13:05:28 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131024154414.GB19055@xxxxxxxxxxxxx>
Organization: Oracle Corporation
References: <20131024154414.GB19055@xxxxxxxxxxxxx>
On Thu, 24 Oct 2013 08:44:14 -0700
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> This test has always been failing for me on my Debian stable system
> with the output below, any idea why this could be?

Looks like the | getfacl_filter_id isn't doing any good on the getfacl
that is being run in the userns because the uids don't match $acl[12]
(which is the point), and the uids that _acl_setup_ids picked are not
the same distance apart as they were on my system. So on your system
$acl2 is not $acl1 + 1.

Let me see about running the second getfacl through a filter that knows
how to replace it based on the delta between $acl1 and $acl2, I think
that should always work.

> --- tests/generic/318.out     2013-09-09 14:41:08.000000000 +0000
> +++ /root/xfstests/results//generic/318.out.bad       2013-10-24
> 15:44:01.000000000 +0000 @@ -17,7 +17,7 @@
>  # group: 65534
>  user::rw-
>  user:0:r-x   #effective:r--
> -user:1:rw-   #effective:r--
> +user:3:rw-   #effective:r--
>  group::r--
>  group:0:--x  #effective:---
>  mask::r--
> @@ -43,7 +43,7 @@
>  # group: 65534
>  user::rw-
>  user:0:r-x   #effective:r--
> -user:1:rw-   #effective:r--
> +user:3:rw-   #effective:r--
>  group::r--
>  group:0:--x  #effective:---
>  mask::r--

<Prev in Thread] Current Thread [Next in Thread>