xfs
[Top] [All Lists]

Re: [PATCH v3 4/4] xfsprog: add mkfs.xfs sb v4 support for dirent filety

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH v3 4/4] xfsprog: add mkfs.xfs sb v4 support for dirent filetype field
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 24 Oct 2013 09:15:14 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131017152955.689963160@xxxxxxx>
References: <20131017152804.204045257@xxxxxxx> <20131017152955.689963160@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 17, 2013 at 10:28:08AM -0500, Mark Tinguely wrote:
> Add directory inode type feature to mkfs.xfs and its manual page.
> 
> In sb v4, "mkfs.xfs -n ftype=1" turns on the feature.
> 
> The feature is automatically turned on for "-m crc=1", but reject
> the use of the "-n ftype=0|1" with the "-m crc=1" option.

Seems like this causes a spurious failure in xfs/206:


--- tests/xfs/206.out   2013-09-09 14:41:08.000000000 +0000
+++ /root/xfstests/results//xfs/206.out.bad     2013-10-24 16:13:54.000000000 
+0000
@@ -5,26 +5,26 @@
          =                       sectsz=512   attr=2
 data     =                       bsize=4096   blocks=3905982455, imaxpct=5
          =                       sunit=0      swidth=0 blks
-naming   =version 2              bsize=4096   ascii-ci=0
+naming   =version 2              bsize=4096   ascii-ci=0 ftype=0
 log      =internal log           bsize=4096   blocks=XXXXX, version=2
          =                       sectsz=512   sunit=0 blks, lazy-count=0
 realtime =none                   extsz=4096   blocks=0, rtextents=0
 === xfs_growfs ===
 meta-data=FILE                   isize=256    agcount=52, agsize=76288719 blks
-         =                       sectsz=512   attr=2
+         =                       sectsz=512   attr=2, projid32bit=1
 data     =                       bsize=4096   blocks=3905982455, imaxpct=5
          =                       sunit=0      swidth=0 blks
-naming   =version 2              bsize=4096   ascii-ci=0
+naming   =version 2              bsize=4096   ascii-ci=0 ftype=0
 log      =internal               bsize=4096   blocks=XXXXX, version=2
          =                       sectsz=512   sunit=0 blks, lazy-count=0
 realtime =none                   extsz=4096   blocks=0, rtextents=0
 data blocks changed from 3905982455 to 4882478016
 === xfs_info ===
 meta-data=FILE                   isize=256    agcount=64, agsize=76288719 blks
-         =                       sectsz=512   attr=2
+         =                       sectsz=512   attr=2, projid32bit=1
 data     =                       bsize=4096   blocks=4882478016, imaxpct=5
          =                       sunit=0      swidth=0 blks
-naming   =version 2              bsize=4096   ascii-ci=0
+naming   =version 2              bsize=4096   ascii-ci=0 ftype=0
 log      =internal               bsize=4096   blocks=XXXXX, version=2
          =                       sectsz=512   sunit=0 blks, lazy-count=0
 realtime =none                   extsz=4096   blocks=0, rtextents=0

<Prev in Thread] Current Thread [Next in Thread>