xfs
[Top] [All Lists]

Re: [PATCH] xfstests: src/feature.c: print a number of online CPUs

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfstests: src/feature.c: print a number of online CPUs
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Thu, 24 Oct 2013 11:18:01 -0200
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131024104042.GT2797@dastard>
Mail-followup-to: xfs@xxxxxxxxxxx
References: <20131023213152.GP2797@dastard> <1382604998-11037-1-git-send-email-stanislav.kholmanskikh@xxxxxxxxxx> <20131024104042.GT2797@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
Hi Dave,

I'm not sure about setting the default to 1 cpu might me a good behavior. My
apologies if I'm saying something wrong, but, if the 'tester' are trying to do
some test trusting on the amount of cpus, it might not be a good behavior.
I was thinking, how about issue an error message if xfstests can't properly
detect the amount of cpus from the system, and add any kind of usage option to
specify the numbers of cpus? So in case of a error while detecting the amount of
cpus.


> 
> Actually, I'd say we shoul default to 1 cpu if we can't get the
> number of CPUs. Clearly we have at least one if we can run this
> code. :)
> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

<Prev in Thread] Current Thread [Next in Thread>