xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 24 Oct 2013 12:09:29 +1100
Cc: Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>, xfs@xxxxxxxxxxx, vasily.isaenko@xxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52686670.6080607@xxxxxxx>
References: <1382529524-2184-1-git-send-email-stanislav.kholmanskikh@xxxxxxxxxx> <1382529524-2184-3-git-send-email-stanislav.kholmanskikh@xxxxxxxxxx> <52686670.6080607@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 23, 2013 at 07:14:40PM -0500, Rich Johnston wrote:
> This has been committed.

Without commiting the other patch that implements
_no_of_online_cpus....

> Thanks
> --Rich
> 
> commit fd080d64b6e9677cb9d0a15dc7e308b6ca0e273f
> Author: Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>
> Date:   Wed Oct 23 11:58:44 2013 +0000
> 
>     xfstests: generic/273: do not use /proc/cpuinfo

generic/273 22s ... - output mismatch (see 
/home/dave/src/xfstests-dev/results//generic/273.out.bad)
    --- tests/generic/273.out   2013-03-28 07:53:08.000000000 +1100
    +++ /home/dave/src/xfstests-dev/results//generic/273.out.bad        
2013-10-24 12:06:27.000000000 +1100
    @@ -2,3 +2,5 @@
     ------------------------------
     start the workload
     ------------------------------
    +./tests/generic/273: line 50: _no_of_online_cpus: command not found
    +./tests/generic/273: line 51: * 50: syntax error: operand expected (error 
token is "* 50")
     ...
     (Run 'diff -u tests/generic/273.out 
/home/dave/src/xfstests-dev/results//generic/273.out.bad' to see the entire 
diff)
Ran: generic/273
Failures: generic/273
Failed 1 of 1 tests

Rich, can you try to commit patch series as a whole, not piecemeal
while parts of the patch series are still being discussed and
reviewed?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>