| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests btrfs/020: test device replace on RO btrfs |
| From: | Eryu Guan <eguan@xxxxxxxxxx> |
| Date: | Thu, 24 Oct 2013 00:41:36 +0800 |
| Cc: | xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <5267F88E.1010607@xxxxxxxxxx> |
| References: | <1382527446-16053-1-git-send-email-eguan@xxxxxxxxxx> <5267F88E.1010607@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 23, 2013 at 11:25:50AM -0500, Eric Sandeen wrote: > On 10/23/13 6:24 AM, Eryu Guan wrote: > > btrfs replace on readonly fs should not be allowed. > > > > Regression test case for commit: > > bbb651e Btrfs: don't allow the replace procedure on read only filesystems > > > > Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx> > > Could you speed this up by just truncating the loop files to 256m, rather > than writing 256m to each (for a total of 768m IO?) Sure, and that does save much time, 7s -> 1s on my test box. V2 will be coming soon. Thanks for the review! Eryu |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfstests btrfs/020: test device replace on RO btrfs, Eric Sandeen |
|---|---|
| Next by Date: | [PATCH v2] xfstests btrfs/020: test device replace on RO btrfs, Eryu Guan |
| Previous by Thread: | Re: [PATCH] xfstests btrfs/020: test device replace on RO btrfs, Eric Sandeen |
| Next by Thread: | [PATCH v2] xfstests btrfs/020: test device replace on RO btrfs, Eryu Guan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |