[Top] [All Lists]

Re: [PATCH 09/19, V2] xfs: decouple inode and bmap btree header files

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 09/19, V2] xfs: decouple inode and bmap btree header files
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 23 Oct 2013 10:48:41 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131022234049.GL2797@dastard>
References: <1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-10-git-send-email-david@xxxxxxxxxxxxx> <20131022182932.GP1935@xxxxxxx> <20131022234049.GL2797@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 23, 2013 at 10:40:49AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> xfs_trans.h has a dependency on xfs_log.h for a couple of
> structures. Most code that does transactions doesn't need to know
> anything about the log, bu this dependency means that they have to
> include xfs_log.h. Decouple the xfs_trans.h and xfs_log.h header
> files and clean up the includes to be in dependency order.
> In doing this, remove the direct include of xfs_trans_reserve.h from
> xfs_trans.h so that we remove the dependency between xfs_trans.h and
> xfs_mount.h. Hence the xfs_trans.h include can be moved to the
> indicate the actual dependencies oher header files have on it.
> Note that these are kernel only header files, so this does not
> translate to any userspace changes at all.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Ben Myers <bpm@xxxxxxx>
> ---
> V2: rebase due to changed fs/xfs/xfs_file.c include files as a
> result of the fallocate rework.

Ignore this patch - it's a rebase for 08/19, not 09/19. I'll send
the rebase for this patch in a minute.

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>