xfs
[Top] [All Lists]

Re: [PATCH 04/19] xfs: create a shared header file for format-related in

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/19] xfs: create a shared header file for format-related information
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 22 Oct 2013 18:12:52 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1381789085-21923-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Oct 15, 2013 at 09:17:50AM +1100, Dave Chinner wrote:
> All of the buffer operations structures are needed to be exported
> for xfs_db, so move them all to a common location rather than
> spreading them all over the place. They are verifying the on-disk
> format, so while xfs_format.h might be a good place, it is not part
> of the on disk format.
> 
> Hence we need to create a new header file that we centralise these
> related definitions. Start by moving the bffer operations
> structures, and then also move all the other definitions that have
> crept into xfs_log_format.h and xfs_format.h as there was no other
> shared header file to put them in.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

/root/xfs/fs/xfs/xfs_file.c
/root/xfs/fs/xfs/xfs_file.c: In function âxfs_file_fallocateâ:
/root/xfs/fs/xfs/xfs_file.c:844: error: âXFS_TRANS_WRITEIDâ undeclared (first 
use in this function)
/root/xfs/fs/xfs/xfs_file.c:844: error: (Each undeclared identifier is reported 
only once
/root/xfs/fs/xfs/xfs_file.c:844: error: for each function it appears in.)
/root/xfs/fs/xfs/xfs_file.c:860: error: âXFS_ICHGTIME_MODâ undeclared (first 
use in this function)
/root/xfs/fs/xfs/xfs_file.c:860: error: âXFS_ICHGTIME_CHGâ undeclared (first 
use in this function)
/root/xfs/fs/xfs/xfs_file.c:864: error: âXFS_TRANS_SYNCâ undeclared (first use 
in this function)
make[1]: *** [/root/xfs/fs/xfs/xfs_file.o] Error 1

Gah.  Maybe due to pulling in Christoph's series.  I'll look into it more
tomorrow.

<Prev in Thread] Current Thread [Next in Thread>