xfs
[Top] [All Lists]

Re: [PATCH 09/19] xfs: decouple inode and bmap btree header files

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/19] xfs: decouple inode and bmap btree header files
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 22 Oct 2013 13:29:32 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1381789085-21923-10-git-send-email-david@xxxxxxxxxxxxx>
References: <1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Oct 15, 2013 at 09:17:55AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Currently the xfs_inode.h header has a dependency on the definition
> of the BMAP btree records as the inode fork includes an array of
> xfs_bmbt_rec_host_t objects in it's definition.
> 
> Move all the btree format definitions from xfs_btree.h,
> xfs_bmap_btree.h, xfs_alloc_btree.h and xfs_ialloc_btree.h to
> xfs_format.h to continue the process of centralising the on-disk
> format definitions. With this done, the xfs inode definitions are no
> longer dependent on btree header files.
> 
> The enables a massive culling of unnecessary includes, with close to
> 200 #include directives removed from the XFS kernel code base.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>