Re: [PATCH 08/19] xfs: decouple log and transaction headers

xfs

Re: [PATCH 08/19] xfs: decouple log and transaction headers

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 08/19] xfs: decouple log and transaction headers
From:	Ben Myers <bpm@xxxxxxx>
Date:	Tue, 22 Oct 2013 12:16:54 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1381789085-21923-9-git-send-email-david@xxxxxxxxxxxxx>
References:	<1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Tue, Oct 15, 2013 at 09:17:54AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> xfs_trans.h has a dependency on xfs_log.h for a couple of
> structures. Most code that does transactions doesn't need to know
> anything about the log, bu this dependency means that they have to
> include xfs_log.h. Decouple the xfs_trans.h and xfs_log.h header
> files and clean up the includes to be in dependency order.
> 
> In doing this, remove the direct include of xfs_trans_reserve.h from
> xfs_trans.h so that we remove the dependency between xfs_trans.h and
> xfs_mount.h. Hence the xfs_trans.h include can be moved to the
> indicate the actual dependencies oher header files have on it.
> 
> Note that these are kernel only header files, so this does not
> translate to any userspace changes at all.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Ben Myers <bpm@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 07/19] xfs: remove unused transaction callback variables, (continued) [PATCH 07/19] xfs: remove unused transaction callback variables, Dave Chinner Re: [PATCH 07/19] xfs: remove unused transaction callback variables, Ben Myers [PATCH 03/19] xfs: prevent deadlock trying to cover an active log, Dave Chinner Re: [PATCH 03/19] xfs: prevent deadlock trying to cover an active log, Eric Sandeen Re: [PATCH 03/19] xfs: prevent deadlock trying to cover an active log, Ben Myers [PATCH 01/19] xfs: xfs_remove deadlocks due to inverted AGF vs AGI lock ordering, Dave Chinner [PATCH 04/19] xfs: create a shared header file for format-related information, Dave Chinner Re: [PATCH 04/19] xfs: create a shared header file for format-related information, Ben Myers [PATCH 04/19, V2] xfs: create a shared header file for format-related information, Dave Chinner [PATCH 08/19] xfs: decouple log and transaction headers, Dave Chinner Re: [PATCH 08/19] xfs: decouple log and transaction headers, Ben Myers <= [PATCH 08/19, V2] xfs: decouple log and transaction headers, Dave Chinner [PATCH 09/19] xfs: decouple inode and bmap btree header files, Dave Chinner Re: [PATCH 09/19] xfs: decouple inode and bmap btree header files, Ben Myers [PATCH 09/19, V2] xfs: decouple inode and bmap btree header files, Dave Chinner Re: [PATCH 09/19, V2] xfs: decouple inode and bmap btree header files, Dave Chinner [PATCH 09/19, V3] xfs: decouple inode and bmap btree header files, Dave Chinner [PATCH 19/19] xfs: convert directory vector functions to constants, Dave Chinner Re: [PATCH 19/19] xfs: convert directory vector functions to constants, Ben Myers Re: [PATCH 19/19] xfs: convert directory vector functions to constants, Dave Chinner Re: [PATCH 19/19] xfs: convert directory vector functions to constants, Ben Myers

Previous by Date:	Investissez dans une valeur sÃre : lâanglais, magazine Vocable
Next by Date:	Re: [PATCH 08/32] xfs: create a shared header file for format-related information, Rich Johnston
Previous by Thread:	[PATCH 08/19] xfs: decouple log and transaction headers, Dave Chinner
Next by Thread:	[PATCH 08/19, V2] xfs: decouple log and transaction headers, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]