xfs
[Top] [All Lists]

Re: [PATCH 05/19] xfs: unify directory/attribute format definitions

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 05/19] xfs: unify directory/attribute format definitions
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 22 Oct 2013 10:33:41 +1100
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131021231129.GM1935@xxxxxxx>
References: <1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-6-git-send-email-david@xxxxxxxxxxxxx> <20131021231129.GM1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 21, 2013 at 06:11:29PM -0500, Ben Myers wrote:
> On Tue, Oct 15, 2013 at 09:17:51AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > The on-disk format definitions for the directory and attribute
> > structures are spread across 3 header files right now, only one of
> > which is dedicated to defining on-disk structures and their
> > manipulation (xfs_dir2_format.h). Pull all the format definitions
> > into a single header file - xfs_da_format.h - and switch all the
> > code over to point at that.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> IIRC Christoph had some concerns with this one, but it wasn't very clear
> exactly what they were.  This looks ok to me.  Christoph did you have anything
> more to add?

I pulled some of the btree specific definitions back into
xfs_btree.h (key, ptr unions), but I left the bmbt_rec-host
definitions in the header as I haven't worked out exactly how to
relocate them without introducing new dependencies everywhere. Hence
I've cleaned up most of what Christoph asked for, but I'm leaving
the hard part for a separate patch(set) where it will be (hopefully)
much clearer what is being moved and what dependencies it
reintroduces.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>