Re: [PATCH 05/19] xfs: unify directory/attribute format definitions

xfs

Re: [PATCH 05/19] xfs: unify directory/attribute format definitions

To:	Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
Subject:	Re: [PATCH 05/19] xfs: unify directory/attribute format definitions
From:	Ben Myers <bpm@xxxxxxx>
Date:	Mon, 21 Oct 2013 18:11:29 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1381789085-21923-6-git-send-email-david@xxxxxxxxxxxxx>
References:	<1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Tue, Oct 15, 2013 at 09:17:51AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The on-disk format definitions for the directory and attribute
> structures are spread across 3 header files right now, only one of
> which is dedicated to defining on-disk structures and their
> manipulation (xfs_dir2_format.h). Pull all the format definitions
> into a single header file - xfs_da_format.h - and switch all the
> code over to point at that.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

IIRC Christoph had some concerns with this one, but it wasn't very clear
exactly what they were.  This looks ok to me.  Christoph did you have anything
more to add?

Reviewed-by: Ben Myers <bpm@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 14/19] xfs: vectorise directory data operations part 2, (continued) [PATCH 14/19] xfs: vectorise directory data operations part 2, Dave Chinner [PATCH 17/19] xfs: vectorise encoding/decoding directory headers, Dave Chinner Re: [PATCH 17/19] xfs: vectorise encoding/decoding directory headers, Ben Myers Re: [PATCH 17/19] xfs: vectorise encoding/decoding directory headers, Ben Myers [PATCH 10/19] xfs: split xfs_rtalloc.c for userspace sanity, Dave Chinner [PATCH 06/19] xfs: split dquot buffer operations out, Dave Chinner [PATCH 11/19] xfs: abstract the differences in dir2/dir3 via an ops vector, Dave Chinner [PATCH 15/19] xfs: vectorise directory leaf operations, Dave Chinner [PATCH 15/19, V2] xfs: vectorise directory leaf operations, Dave Chinner [PATCH 05/19] xfs: unify directory/attribute format definitions, Dave Chinner Re: [PATCH 05/19] xfs: unify directory/attribute format definitions, Ben Myers <= Re: [PATCH 05/19] xfs: unify directory/attribute format definitions, Dave Chinner Re: [PATCH 05/19] xfs: unify directory/attribute format definitions, Christoph Hellwig Re: [PATCH 00/19 V2] xfs: patches for 3.13, Ben Myers

Previous by Date:	Re: [PATCH] xfs: fix possible NULL dereference, Dave Chinner
Next by Date:	Re: [PATCH] xfs: fix possible NULL dereference, Eric Sandeen
Previous by Thread:	[PATCH 05/19] xfs: unify directory/attribute format definitions, Dave Chinner
Next by Thread:	Re: [PATCH 05/19] xfs: unify directory/attribute format definitions, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]