xfs
[Top] [All Lists]

Re: [PATCH 05/19] xfs: unify directory/attribute format definitions

To: Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 05/19] xfs: unify directory/attribute format definitions
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 21 Oct 2013 18:11:29 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1381789085-21923-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Oct 15, 2013 at 09:17:51AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The on-disk format definitions for the directory and attribute
> structures are spread across 3 header files right now, only one of
> which is dedicated to defining on-disk structures and their
> manipulation (xfs_dir2_format.h). Pull all the format definitions
> into a single header file - xfs_da_format.h - and switch all the
> code over to point at that.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

IIRC Christoph had some concerns with this one, but it wasn't very clear
exactly what they were.  This looks ok to me.  Christoph did you have anything
more to add?

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>